Remove "proxy" references and fix scripts' paths#210
Open
ldko wants to merge 2 commits intointernetarchive:masterfrom
Open
Remove "proxy" references and fix scripts' paths#210ldko wants to merge 2 commits intointernetarchive:masterfrom
ldko wants to merge 2 commits intointernetarchive:masterfrom
Conversation
TheTechRobo
approved these changes
Nov 17, 2021
Contributor
TheTechRobo
left a comment
TheTechRobo
left a comment
There was a problem hiding this comment.
Should work - I tried removing proxy argument, and it still used warcprox. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying out Brozzler via the Vagrant setup provided in the repo, I hit a couple things that could possibly use updating. If it is of interest, I have included them here.
The PR removes references to "proxy" in the job-conf.rst and vagrant/README.rst, which, as far as I could tell, is no longer a valid field in configuring jobs, as it is also no longer a valid flag when calling
brozzler-new-site.This also updates the virtualenv path in
vagrant/vagrant-brozzler-new-job.pywhere it was no longer accurate and adds use ofos.path.realpathto allow flexibility in the directory from which the vagrant-brozzler-* scripts are run.